Skip to content

android-interop-testing: add AndroidX Test core in implementation - #12718

Merged
shivaspeaks merged 5 commits into
grpc:masterfrom
shivaspeaks:fix-android-test-issue
Mar 23, 2026
Merged

android-interop-testing: add AndroidX Test core in implementation#12718
shivaspeaks merged 5 commits into
grpc:masterfrom
shivaspeaks:fix-android-test-issue

Conversation

@shivaspeaks

@shivaspeaks shivaspeaks commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This alignment resolves a version skew issue that caused NoClassDefFoundError crashes during instrumentation tests on Firebase Test Lab.

Fixes #12703 (comment)

@shivaspeaks shivaspeaks added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Mar 19, 2026
@shivaspeaks shivaspeaks added kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run and removed kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Mar 19, 2026
@ejona86

ejona86 commented Mar 19, 2026

Copy link
Copy Markdown
Member

Please test this by running the tests using gcloud firebase. Refer to the CI:

grpc-java/buildscripts/kokoro/android-interop.sh

Lines 31 to 43 in 91e9491

gcloud firebase test android run \
--type instrumentation \
--app android-interop-testing/build/outputs/apk/debug/grpc-android-interop-testing-debug.apk \
--test android-interop-testing/build/outputs/apk/androidTest/debug/grpc-android-interop-testing-debug-androidTest.apk \
--environment-variables \
server_host=grpc-test.sandbox.googleapis.com,server_port=443,test_case=all \
--device model=MediumPhone.arm,version=30,locale=en,orientation=portrait \
--device model=MediumPhone.arm,version=29,locale=en,orientation=portrait \
--device model=MediumPhone.arm,version=28,locale=en,orientation=portrait \
--device model=MediumPhone.arm,version=27,locale=en,orientation=portrait \
--device model=MediumPhone.arm,version=26,locale=en,orientation=portrait \
--device model=Nexus6P,version=25,locale=en,orientation=portrait \
--device model=Nexus6P,version=24,locale=en,orientation=portrait \

@ejona86

ejona86 commented Mar 19, 2026

Copy link
Copy Markdown
Member

which triggered a "classpath split" issue.

Are you sure? You're telling me that implementation is not part of androidTestImplementation deps? That seems unlikely.

What seems more likely is there's a version skew problem.

@shivaspeaks

shivaspeaks commented Mar 19, 2026

Copy link
Copy Markdown
Member Author

It's passing:

https://firebase.corp.google.com/u/0/project/grpc-testing/testlab/histories/bh.6e2cfdde264f9eb3/matrices/8362364768452618648/details?stepId=bs.eb4178e154783026&testCaseId=1

ejona86
ejona86 reviewed Mar 19, 2026
View reviewed changes
Comment thread android-interop-testing/build.gradle Outdated
@shivaspeaks
shivaspeaks requested a review from ejona86 March 19, 2026 19:13
ejona86
ejona86 approved these changes Mar 19, 2026
View reviewed changes

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to reword the title, and maybe tweak the description.

@shivaspeaks shivaspeaks changed the title android-interop-testing: add AndroidX Test core and rules to androidTestImplementation android-interop-testing: add AndroidX Test core in implementation Mar 19, 2026
@shivaspeaks

shivaspeaks commented Mar 19, 2026

Copy link
Copy Markdown
Member Author

Is there a problem with Kokoro? It's not running, I tried with kokoro force run as well, but it didn't run.

@shivaspeaks shivaspeaks added kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run and removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Mar 23, 2026
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 23, 2026
@shivaspeaks
shivaspeaks merged commit 6b3e2b3 into grpc:master Mar 23, 2026
21 of 23 checks passed
@shivaspeaks
shivaspeaks deleted the fix-android-test-issue branch April 2, 2026 12:20
kannanjgithub pushed a commit to kannanjgithub/grpc-java that referenced this pull request May 4, 2026
@shivaspeaks @kannanjgithub
android-interop-testing: add AndroidX Test core in implementation (gr…
4f08ef6 
…pc#12718)

This alignment resolves a version skew issue that caused
NoClassDefFoundError crashes during instrumentation tests on Firebase
Test Lab.

Fixes
grpc#12703 (comment)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes
@kannanjgithub kannanjgithub kannanjgithub approved these changes
@AgraVator AgraVator AgraVator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shivaspeaks @ejona86 @kannanjgithub @AgraVator @grpc-kokoro